Add Subaru driver torque sensor Nm scaling factor and unit

.github/labeler.yaml

@@ -0,0 +1,68 @@
+CI / testing:
+  - changed-files:
+    - any-glob-to-any-file: '.github/**'
+
+car:
+  - changed-files:
+    - any-glob-to-any-file: 'opendbc/car/**'
+
+can:
+  - changed-files:
+    - any-glob-to-any-file: 'opendbc/can/**'
+
+DBC signals:
+  - changed-files:
+    - any-glob-to-any-file: 'opendbc/dbc/**'
+
+
+body:
+  - changed-files:
+    - any-glob-to-any-file: 'opendbc/car/body/**'
+
+chrysler:
+  - changed-files:
+    - any-glob-to-any-file: 'opendbc/car/chrysler/**'
+
+ford:
+  - changed-files:
+    - any-glob-to-any-file: 'opendbc/car/ford/**'
+
+gm:
+  - changed-files:
+    - any-glob-to-any-file: 'opendbc/car/gm/**'
+
+honda:
+  - changed-files:
+    - any-glob-to-any-file: 'opendbc/car/honda/**'
+
+hyundai:
+  - changed-files:
+    - any-glob-to-any-file: 'opendbc/car/hyundai/**'
+
+mazda:
+  - changed-files:
+    - any-glob-to-any-file: 'opendbc/car/mazda/**'
+
+nissan:
+  - changed-files:
+    - any-glob-to-any-file: 'opendbc/car/nissan/**'
+
+subaru:
+  - changed-files:
+    - any-glob-to-any-file: 'opendbc/car/subaru/**'
+
+tesla:
+  - changed-files:
+    - any-glob-to-any-file: 'opendbc/car/tesla/**'
+
+toyota:
+  - changed-files:
+    - any-glob-to-any-file: 'opendbc/car/toyota/**'
+
+volkswagen:
+  - changed-files:
+    - any-glob-to-any-file: 'opendbc/car/volkswagen/**'
+
+fingerprint:
+  - changed-files:
+    - any-glob-to-any-file: 'opendbc/car/*/fingerprints.py'

.github/workflows/auto_pr_review.yaml

@@ -0,0 +1,50 @@
+name: "PR review"
+on:
+  pull_request_target:
+    types: [opened, reopened, synchronize, edited, edited]
+
+jobs:
+  labeler:
+    name: review
+    permissions:
+      contents: read
+      pull-requests: write
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v4
+
+    # Label PRs
+    - uses: actions/[email protected]
+      with:
+        dot: true
+        configuration-path: .github/labeler.yaml
+
+    # Check PR target branch
+    - name: check branch
+      uses: Vankka/pr-target-branch-action@def32ec9d93514138d6ac0132ee62e120a72aed5
+      if: github.repository == 'commaai/opendbc'
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      with:
+        target: /^(?!master$).*/
+        exclude: /commaai:.*/
+        change-to: ${{ github.base_ref }}
+        already-exists-action: close_this
+        already-exists-comment: "Your PR should be made against the `master` branch"
+
+    # Welcome comment
+    - name: comment
+      uses: thollander/actions-comment-pull-request@fabd468d3a1a0b97feee5f6b9e499eab0dd903f6
+      if: github.event.pull_request.head.repo.full_name != 'commaai/opendbc'
+      with:
+        message: |
+            <!-- _(run_id **${{ github.run_id }}**)_ -->
+            Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:
+            * Convert your PR to a draft unless it's ready to review
+            * Read the [contributing docs](https://github.com/commaai/openpilot/blob/master/docs/CONTRIBUTING.md)
+            * Before marking as "ready for review", ensure:
+              * the goal is clearly stated in the description
+              * all the tests are passing
+              * include a route or your device' dongle ID if relevant
+        comment_tag: run_id
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/repo.yml

@@ -2,17 +2,17 @@ name: repo
 
 on:
   schedule:
-    - cron: "0 15 * * 2"
+    - cron: "0 15 1 * *"
   workflow_dispatch:
 
 jobs:
   pre-commit-autoupdate:
     name: pre-commit autoupdate
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
     container:
       image: ghcr.io/commaai/opendbc:latest
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     - name: pre-commit autoupdate
       run: |
         git config --global --add safe.directory '*'

.github/workflows/tests.yml

@@ -1,57 +1,52 @@
 name: tests
 
-on: [push, pull_request]
+on:
+  push:
+    branches:
+      - master
+  pull_request:
 
-env:
-  RUN: docker run -v $GITHUB_WORKSPACE:/project/opendbc -w /project/opendbc -e PYTHONWARNINGS="error,default::DeprecationWarning" --shm-size 1G --rm opendbc /bin/bash -c
-  BUILD: |
-      docker pull $(grep -ioP '(?<=^from)\s+\S+' Dockerfile) || true
-      docker pull ghcr.io/commaai/opendbc:latest || true
-      docker build --cache-from ghcr.io/commaai/opendbc:latest -t opendbc -f Dockerfile .
-  PYTHONWARNINGS: error
+# TODO: enable this
+#env:
+#  PYTHONWARNINGS: error,default::DeprecationWarning
 
 jobs:
   unit-tests:
     name: unit tests
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
+    timeout-minutes: 1
     #strategy:
     #  fail-fast: false
     #  matrix:
     #    run: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14]
     steps:
-    - uses: actions/checkout@v3
-    - name: Build Docker image
-      run: eval "$BUILD"
-    - name: Build opendbc
-      run: ${{ env.RUN }} "cd ../ && scons -j$(nproc)"
-    - name: Unit tests
-      run: ${{ env.RUN }} "python -m unittest discover ."
+    - uses: actions/checkout@v4
+    - name: setup python
+      run: |
+        curl -LsSf https://astral.sh/uv/install.sh | sh
+        uv venv
+        # TODO: remove setuptools once https://github.com/cython/cython/issues/5751 is fixed
+        uv pip install -e .[testing,docs] setuptools
+    - run: uv run scons -j$(nproc)
+    - run: uv run pytest .
 
   static-analysis:
     name: static analysis
-    runs-on: ubuntu-20.04
-    steps:
-    - uses: actions/checkout@v3
-    - name: Build Docker image
-      run: eval "$BUILD"
-    - name: Build opendbc
-      run: ${{ env.RUN }} "cd ../ && scons -j$(nproc)"
-    - name: pre-commit
-      # TODO: a package pre-commit installs has a warning, remove the unset once that's fixed
-      run: ${{ env.RUN }} "unset PYTHONWARNINGS && pre-commit run --all"
-    - name: Generator test
-      run: ${{ env.RUN }} "generator/test_generator.py"
-
-  docker-push:
-    name: docker push
-    runs-on: ubuntu-20.04
-    if: github.ref == 'refs/heads/master' && github.event_name != 'pull_request' && github.repository == 'commaai/opendbc'
+    runs-on: ubuntu-24.04
+    timeout-minutes: 1
     steps:
-    - uses: actions/checkout@v3
-    - name: Build Docker image
-      run: eval "$BUILD"
-    - name: Push to dockerhub
+    - uses: actions/checkout@v4
+    - run: sudo apt install --no-install-recommends -y cppcheck
+    - name: setup python
       run: |
-        docker login ghcr.io -u ${{ github.actor }} -p ${{ secrets.GITHUB_TOKEN }}
-        docker tag opendbc ghcr.io/commaai/opendbc:latest
-        docker push ghcr.io/commaai/opendbc:latest
+        curl -LsSf https://astral.sh/uv/install.sh | sh
+        uv venv
+        uv pip install -e . pre-commit
+    - name: cache pre-commit environments
+      uses: actions/cache@v4
+      with:
+        path: ~/.cache/pre-commit
+        key: ${{ runner.os }}-pre-commit-${{ hashFiles('.pre-commit-config.yaml') }}
+        restore-keys: |
+          ${{ runner.os }}-pre-commit-
+    - run: uv run pre-commit run --all

.gitignore

@@ -1,3 +1,4 @@
+/build/
 .mypy_cache/
 *.pyc
 *.os
@@ -7,12 +8,14 @@
 .*.swp
 .DS_Store
 .sconsign.dblite
+.hypothesis
+*.egg-info/
 
-can/*.so
-can/*.a
-can/build/
-can/obj/
-can/packer_pyx.cpp
-can/parser_pyx.cpp
-can/packer_pyx.html
-can/parser_pyx.html
+opendbc/can/*.so
+opendbc/can/*.a
+opendbc/can/build/
+opendbc/can/obj/
+opendbc/can/packer_pyx.cpp
+opendbc/can/parser_pyx.cpp
+opendbc/can/packer_pyx.html
+opendbc/can/parser_pyx.html

.pre-commit-config.yaml

@@ -1,44 +1,28 @@
 repos:
 -   repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.4.0
+    rev: v4.5.0
     hooks:
     -   id: check-ast
     -   id: check-yaml
     -   id: check-merge-conflict
     -   id: check-symlinks
+    -   id: check-executables-have-shebangs
+    -   id: check-shebang-scripts-are-executable
 -   repo: https://github.com/codespell-project/codespell
-    rev: v2.2.5
+    rev: v2.3.0
     hooks:
     -   id: codespell
         exclude: '\.dbc$'
-        args:
-        - --check-hidden
-        - --builtins clear,rare,informal,usage,code,names,en-GB_to_en-US
 -   repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v1.4.1
+    rev: v1.11.1
     hooks:
     -   id: mypy
--   repo: https://github.com/PyCQA/flake8
-    rev: 6.0.0
-    hooks:
-    -   id: flake8
-        exclude: 'site_scons/'
-        args:
-        - --select=F,E112,E113,E304,E501,E502,E701,E702,E703,E71,E72,E731,W191,W6
-        - --max-line-length=240
-        - --statistics
--   repo: local
+-   repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.5.7
     hooks:
-    -   id: pylint
-        name: pylint
-        entry: pylint
-        language: system
-        types: [python]
-        exclude: 'site_scons/'
-        args:
-        - --disable=C,R,W0613,W0511,W0212,W0201,W0311,W0106,W0603,W0621,W0703,E1136
+    - id: ruff
 -   repo: https://github.com/MarcoGorelli/cython-lint
-    rev: v0.15.0
+    rev: v0.16.0
     hooks:
     -   id: cython-lint
     -   id: double-quote-cython-strings
@@ -50,7 +34,7 @@ repos:
         - --quiet
         - --counting=detailed
         - --linelength=240
-        - --filter=-legal,-build/include_order,-readability/casting,-whitespace/braces,-whitespace/indent,-whitespace/operators,-build/c++11,-readability/todo,-runtime/explicit,-runtime/int,-whitespace/comments,-readability/braces,-runtime/arrays,-runtime/references
+        - --filter=-build,-legal,-readability,-runtime,-whitespace,+build/include_subdir,+build/forward_decl,+build/include_what_you_use,+build/deprecated,+whitespace/comma,+whitespace/line_length,+whitespace/empty_if_body,+whitespace/empty_loop_body,+whitespace/empty_conditional_body,+whitespace/forcolon,+whitespace/parens,+whitespace/semicolon,+whitespace/tab,+readability/braces
 -   repo: local
     hooks:
     -   id: cppcheck
@@ -61,13 +45,14 @@ repos:
         args:
         - --error-exitcode=1
         - --language=c++
+        - --inline-suppr
         - --force
         - --quiet
         - -j4
 -   repo: local
     hooks:
     -   id: generator
         name: dbc generator
-        entry: generator/test_generator.py
+        entry: opendbc/dbc/generator/test_generator.py
         language: script
         pass_filenames: false