Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Subaru driver torque sensor Nm scaling factor and unit #901

Closed
wants to merge 148 commits into from
Closed

Add Subaru driver torque sensor Nm scaling factor and unit #901

wants to merge 148 commits into from

Conversation

martinl
Copy link
Contributor

@martinl martinl commented Jul 18, 2023

This PR adds Nm unit for Subaru driver torque sensor signal, matched with SSM4 signal output by to jnewb1 at
martinl/openpilot#80

I will update openpilot carstate when this PR passes initial review

@martinl martinl mentioned this pull request Jul 18, 2023
Open
@adeebshihadeh
Copy link
Contributor

Seems fine, want to update the interface?

@adeebshihadeh adeebshihadeh marked this pull request as draft August 28, 2024 21:05
@martinl
Copy link
Contributor Author

martinl commented Aug 29, 2024

I will open new PR due to complicated git history

@martinl martinl closed this Aug 29, 2024
@martinl martinl reopened this Aug 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 29, 2024 •
edited
Loading

Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • include a route or your device' dongle ID if relevant

maxime-desroches and others added 22 commits August 29, 2024 07:23
@maxime-desroches @martinl
Update cython (commaai#903)
045dc5b 
* cython

* ref

* test

* Werror
@jnewb1 @martinl
Subaru: ALT LKAS request is actually angle (commaai#904)
5f19a5e 
alt is angle
@adeebshihadeh @martinl
pre-commit: autoupdate hooks commaai#908
8053570
@MonsterPerformance @martinl
Hyundai SantaFe CM and Opel Omega B databases added (commaai#910)
b753c4c 
* Hyundai: SantaFe CM database

* Opel: Omega B database
@sshane @martinl
'test_dbc_parser: ensure we're running on real DBCs'
89e85eb 
Split from commaai#828
@jnewb1 @martinl
CI: Pylint to ruff (commaai#911)
1a09ba7
@adeebshihadeh @martinl
disable parser perf test for now
cbce201
@cydia2020 @sshane @martinl
Toyota: rename ACC_HUD to PCS_HUD (commaai#905)
bdb16b8 
* Toyota: rename ACC_HUD to PCS_HUD

* run generator

---------

Co-authored-by: Shane Smiskol <[email protected]>
@sunnyhaibin @martinl
Toyota: Follow distance signal for unsupported DSU cars (commaai#915)
7eb6a68 
* Toyota: add follow distance signal for unsupported DSU cars

* Update with generator
@fredyshox @sshane @martinl
parser: update_strings propagate cpp exceptions in py bindings (comma…
b612b79 
…ai#912)

* Propagate cpp exceptions to py

* Add a test case

* Update can/tests/test_dbc_exceptions.py

Co-authored-by: Shane Smiskol <[email protected]>

---------

Co-authored-by: Shane Smiskol <[email protected]>
@adeebshihadeh @sshane @martinl
CANParser: parse all signals for given messages (commaai#828)
082ec64 
* CANParser: parse all signals for a message

* update tests

* just use a pair

* rm enforce checks

* rm that

* spacing

* fix nonexistent message test

* message addr check should not have been deleted

* can be cleaned up more

* remove that too

* add comment back

* revert default bus behavior

revert default bus behavior

* can combine this loop

* unused map

* add all

* ensure we track all signals

* remove sanity check

* this wasn't tested before

* Revert "this wasn't tested before"

This reverts commit eb5e920.

---------

Co-authored-by: Shane Smiskol <[email protected]>
@jnewb1 @martinl
Ruff: propogate config from OP (commaai#916)
8d257bc
@adeebshihadeh @martinl
pre-commit: autoupdate hooks (commaai#917)
9abebcf 
Update pre-commit hook versions

Co-authored-by: adeebshihadeh <[email protected]>
@sshane @martinl
Hyundai CAN FD: fix wheel speed units (commaai#919)
95dfb19 
kph
@jnewb1 @martinl
Subaru: added static and hba signals (commaai#920)
57f5780 
added static signals
@martinl
Subaru: Remove unrelated bit from transmission RPM signal (commaai#918)
4d88fc5 
* Remove unrelated bit from transmission RPM signal

* run generator
@jnewb1 @martinl
Subaru: more dbc updates for long (commaai#859)
a25f05b 
add set speed and low speed follow
@sunnyhaibin @sshane @martinl
Hyundai CAN-FD: Alternate LKAS and BLINKERS signals (commaai#892)
c9f3100 
* Hyundai CAN-FD: new steering message

* bruh

* new blinker signals for 2nd Gen Kona

* add comment

* speed isn't on kona

* update comment

* update blinkers

---------

Co-authored-by: Shane Smiskol <[email protected]>
@FLcruising @incognitojam @martinl
VW PQ: AWV_only signal fix (commaai#921)
93ab956 
* VW PQ: AWV_only signal fix

AVW_only signal length is 1 (not 4)

* Update vw_golf_mk4.dbc

Indeed. Thanks!

Co-authored-by: Cameron Clough <[email protected]>

---------

Co-authored-by: Cameron Clough <[email protected]>
@adeebshihadeh @martinl
pre-commit: autoupdate hooks (commaai#922)
fa30505 
Update pre-commit hook versions

Co-authored-by: adeebshihadeh <[email protected]>
@deanlee @martinl
cpplint: more filters (commaai#925)
340f85f 
more filters
@adeebshihadeh @martinl
update build flag
f57d6f2
sshane and others added 12 commits August 29, 2024 07:23
@sshane @martinl
rename car label
2b459da
@adeebshihadeh @martinl
add opendbc/can/ to LIBPATH
1db5977
@sshane @martinl
fixup auto labeler (commaai#1089)
9ea205c 
* test

* test

* test

* make sure to detect subdirectories like tests/

* test

* this should work

* this should work

* wtf is this

* test

* clean up

* test

* test

* clean up

* clean up
@sshane @martinl
add test_lateral_limits.py
8302ca3
@sshane @martinl
add banned apis
8eef816
@sshane @martinl
speedup CI (commaai#1179)
4ee3450 
* no setup python

* replace with uv

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* slightly faster

* this doesnt do anything without seen ecus

* test

* is durations slow?

* not now

* test in another pr

* same to static

* static

* test

* test

* test

* the action used to cache as well

* test
@sshane @martinl
add test_car_interfaces.py (commaai#1178)
61b253d 
* add test_car_interfaces.py

* rm op stuff

* fix

* justsee

* optimize get_fuzzy_car_interface_args a bit

* Revert "optimize get_fuzzy_car_interface_args a bit"

This reverts commit ba4d07f.

* lower examples for now

* sheesh

* revert time
@sshane @martinl
tests: some speed optimizations (commaai#1181)
e09719b 
* mock sleep via monotonic

* rm

* no need to generate 8 buses

* this doesn't actually make a big diff

* lower loop

* can reduce

* here too

* Revert "here too"

This reverts commit 06b4cad.

* Revert "can reduce"

This reverts commit 55cae02.
@adeebshihadeh @martinl
openpilot isn't required for a car port PR (commaai#1183)
b62b56a 
* move test routes here

* check for missing

* no shebang
@adeebshihadeh @martinl
CI should use the defaults
7e7da74
@sshane @martinl
GM: implement allow throttle/brakes (commaai#1185)
75f4408 
implement allow gnb for GM
@sshane @martinl
Revert "GM: implement allow throttle/brakes" (commaai#1187)
68cfa7c 
Revert "GM: implement allow throttle/brakes (commaai#1185)"

This reverts commit 8e20376.
@martinl martinl closed this Aug 29, 2024
@martinl
Copy link
Contributor Author

martinl commented Aug 29, 2024

New PR #1198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
body can related to CAN tools, aka opendbc/can/ car related to opendbc/car/ chrysler CI / testing DBC signals fingerprint ford gm honda hyundai mazda nissan subaru toyota volkswagen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.