DDF-2687 Update vendored DrawHelper to not remove overlapping points #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- See leforthomas/cesium-drawhelper#13 for details. - At lower zooms, points were being erroneously removed from drawings.
kcwire
approved these changes
Jan 6, 2017
jlcsmith
approved these changes
Jan 6, 2017
rzwiefel
approved these changes
Jan 11, 2017
|
Hero build successful. |
andrewkfiedler
added a commit
to andrewkfiedler/ddf
that referenced
this pull request
Feb 6, 2017
- codice#1534 made a change to DrawHelper which allowed drawings at higher zooms to work. However, DrawHelper was relying on this to remove the extra points that occur when finishing a drawing. As a result, we need to remove the final two points on all polygon / line drawings.
rzwiefel
pushed a commit
to codice/ddf-ui
that referenced
this pull request
Nov 8, 2019
…#1647) - codice/ddf#1534 made a change to DrawHelper which allowed drawings at higher zooms to work. However, DrawHelper was relying on this to remove the extra points that occur when finishing a drawing. As a result, we need to remove the final two points on all polygon / line drawings.
lavoywj
pushed a commit
to lavoywj/ddf
that referenced
this pull request
Feb 13, 2020
…odice#1534) - See leforthomas/cesium-drawhelper#13 for details. - At lower zooms, points were being erroneously removed from drawings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the vendored version of DrawHelper to pull in a fix for lower zoom drawings.
Who is reviewing it (please choose AT LEAST two reviewers that need to approve the PR before it can get merged)?
@jlcsmith
@kcwire
Select at least one member from relevant component team(s) from below (at least one component team member needs to approve the PR).
UI
Choose 2 committers to review/merge the PR (please choose ONLY two committers from below, delete the rest).
@jlcsmith
@kcwire
How should this be tested? (List steps with links to updated documentation)
Zoom to street level somewhere and draw a line or a polygon.
Any background context you want to provide?
This applies the fix to both the standard and the catalog ui.
What are the relevant tickets?
https://codice.atlassian.net/browse/DDF-2687
Screenshots (if appropriate)
Before: https://gfycat.com/SereneSelfassuredBoto
After: https://gfycat.com/ElectricLittleHummingbird