DDF-2779 Remove extra points from line / polygon drawings in Cesium #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- codice#1534 made a change to DrawHelper which allowed drawings at higher zooms to work. However, DrawHelper was relying on this to remove the extra points that occur when finishing a drawing. As a result, we need to remove the final two points on all polygon / line drawings.
pklinef
approved these changes
Feb 7, 2017
|
Manually verified 👍 |
shaundmorris
approved these changes
Feb 8, 2017
This was referenced Feb 14, 2017
lavoywj
pushed a commit
to lavoywj/ddf
that referenced
this pull request
Feb 13, 2020
…odice#1647) - codice#1534 made a change to DrawHelper which allowed drawings at higher zooms to work. However, DrawHelper was relying on this to remove the extra points that occur when finishing a drawing. As a result, we need to remove the final two points on all polygon / line drawings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Who is reviewing it (please choose AT LEAST two reviewers that need to approve the PR before it can get merged)?
@djblue
@garrettfreibott
@andrewkfiedler
@pklinef
How should this be tested? (List steps with links to updated documentation)
Create line and polygon drawings in Cesium and verify that they contain only the number of points you that were drawn.
What are the relevant tickets?
https://codice.atlassian.net/browse/DDF-2779