-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added data types in Lua #692
Conversation
Please add 'hacktoberfest-accepted' label if you are satisfied with PR. |
Hey, thanks for adding this! First, can you leave a comment on #580 to claim it as yours? (You checked it on the PR but you didn't actually do it.) Sometimes multiple people try to work on an issue together and it sucks that someone doesn't know someone else is working on it. Second, the whole project is opted in to Hacktoberfest, no label needed on the PR. Third, multiple things like signed and unsigned 8-bit integers are "Undefined" because you didn't specify if they do or don't exist in the language. You should fill those in and if the language doesn't have them, mark them as "not-implemented". (See the documentation on why.) You can use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing concepts leaving "unknown" answers on the pages.
#692 isn't accepted because I haven't merged it in yet. When I do merge it, it should go into waiting and then be approved after 7 days. (This works for everyone so far, including me.) https://github.com/thecuriousteam/pyliblog should automatically work because For the Ex: signed 8-bit integers are "unknown" because
is missing. |
Okayy, I'll correct it soon. |
btw @geekygirlsarah, this same thing is also happening in Python's data types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the other fields back in. I'll approve and merge! Happy Hacktoberfest!
Yes, Python, C++, and Java data types were the first 3 things added to CT back in 2017 or so. The data types concept has evolved since then and no one's gone back to update them. There's a few other holes in thesauruses and just merged in a feature to point out they could be contributed to. |
I see, I'm planning to close all issue related to Lua then i would like resolve it. |
What GitHub issue does this PR apply to?
Resolves #580
What changed and why?
I added data type feature for Lua as per issue #580
(If editing Django app) Please add screenshots
Checklist
Last year(Hacktoberfest2022) i worked for Lua language for codethesaur.us so i have already familiar with this project.