Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KSPACE-43: Adding common GetClusters func-memberpair #923

Closed

Conversation

fbm3307
Copy link
Contributor

@fbm3307 fbm3307 commented Mar 14, 2024

Adding a new common function GetClusters() in toolchain-common and using it in Member Operator to fetch the clusters from cache as we have dropped the cluster type as per changes in toolchain-common
This is a paired PR for Member Operator changes

Related PRs
Toolchain-common - codeready-toolchain/toolchain-common#372
Member-Operator - codeready-toolchain/member-operator#543

Copy link

openshift-ci bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fbm3307
Once this PR has been reviewed and has the lgtm label, please assign matousjobanek for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@fbm3307
Copy link
Contributor Author

fbm3307 commented Mar 19, 2024

Closing this PR as Adding the Common Getcluster Func is not required now

@fbm3307 fbm3307 closed this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant