KSPACE-43: Adding common GetClusters func #543
Conversation
Signed-off-by: Feny Mehta <[email protected]>
fbm3307
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fbm3307 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Feny Mehta <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #543 +/- ##
==========================================
+ Coverage 84.05% 84.06% +0.01%
==========================================
Files 29 29
Lines 2634 2636 +2
==========================================
+ Hits 2214 2216 +2
Misses 277 277
Partials 143 143
|
| @@ -56,7 +56,7 @@ type Reconciler struct { | |||
| AllNamespacesClient client.Client | |||
| ScalesClient scale.ScalesGetter | |||
| DynamicClient dynamic.Interface | |||
| GetHostCluster cluster.GetHostClusterFunc | |||
| GetHostCluster cluster.GetClustersFunc | |||
There was a problem hiding this comment.
The name of the parameter is GetHostCluster in a singular form, but the function can return 0..n objects. Let's either change the name or the type of the parameter
| allclustersCl := reconciler.GetHostCluster() | ||
| hostCl := allclustersCl[0] |
There was a problem hiding this comment.
this could work too, right?
| allclustersCl := reconciler.GetHostCluster() | |
| hostCl := allclustersCl[0] | |
| hostCl := reconciler.GetHostCluster()[0] |
|
|
Closing this PR as Adding the Common Getcluster Func is not required now |
Adding a new common function GetClusters() to fetch the clusters from cache as we have dropped the cluster type as per changes in toolchain-common
Related PRs
Toolchain-common - codeready-toolchain/toolchain-common#372
Paired-Toolchain-e2e - codeready-toolchain/toolchain-e2e#923