Add tests for VM webhook #809
Conversation
testsupport/wait/member.go
Outdated
| func (a *MemberAwaitility) verifyUserPodWebhookConfig(t *testing.T, ca []byte) { | ||
| t.Logf("checking MutatingWebhookConfiguration '%s'", "sandbox-users-pods") | ||
| func (a *MemberAwaitility) verifyMutatingWebhookConfig(t *testing.T, ca []byte) { | ||
| if val := os.Getenv("skip-mutating-webhook-check-on-setup"); val == "true" { |
There was a problem hiding this comment.
minor thing - this will disable also the test for the users pod mutating webhook if I'm not wrong. But I guess not a big deal since you'll renable it quickly once the member pr is merged.
Unless you end up like me , and realize 2 weeks later the the test for the webhook is still disabled 🤣
There was a problem hiding this comment.
yeah, but both are still checked in the after migration test so it's okay. But yes, I'll have a reminder to enable it again haha
Yes, I'll add them to this PR. I was looking for an official place to get the CRDs from but didn't find one so will have to ask if there is an official place like we have for the appstudio CRDs. I can grab one from a cluster and use that temporarily though so I'll add that when I'm back. |
… into vmWebhookLimits
Tests added, sorry for the delay |
| // set env var to skip the mutating webhook check on migration setup temporarily since the old deployment | ||
| // will deploy the webhooks with the old configuration but the tests will be expecting the new configuration | ||
| // This should be removed after PR https://github.com/codeready-toolchain/toolchain-e2e/pull/809 is merged | ||
| t.Setenv("skip-webhook-checks-on-setup", "true") |
There was a problem hiding this comment.
Let's try not forget to re-enable it after merging the PR! :)
MatousJobanek
requested review from
MatousJobanek,
ranakan19 and
sbryzak
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, rajivnathan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e2e tests for codeready-toolchain/member-operator#477