Re-enable webhook checks on migration setup test #822
Conversation
rajivnathan
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
ranakan19,
sbryzak and
mfrancisc
as code owners
| @@ -2240,12 +2239,6 @@ func (a *MemberAwaitility) verifySecret(t *testing.T) []byte { | |||
| } | |||
|
|
|||
| func (a *MemberAwaitility) verifyMutatingWebhookConfig(t *testing.T, ca []byte) { | |||
| if val := os.Getenv("skip-webhook-checks-on-setup"); val == "true" { | |||
There was a problem hiding this comment.
Or we could keep it and just out the setting of this environment variable in the migration tests for future use in the comment (and keep the description of what it is for). But I will keep it up to you to decide :)
There was a problem hiding this comment.
Actually, I was thinking we probably don't need to verify webhooks as part of the migration setup tests. I just had a discussion with @MatousJobanek about this and he agreed. So I think we can simplify it by doing some refactoring to skip verification of webhook configuration and maybe some other things too so that we don't need to do this dance repeatedly whenever we make such changes. I'll handle that in a separate PR.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, mfrancisc, rajivnathan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Kudos, SonarCloud Quality Gate passed!
|
Follow up to #809