Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop unnecessary SignupService methods #480

Merged
merged 2 commits into from
Oct 14, 2024

rename

654d33d
Select commit
Loading
Failed to load commit list.
Merged

drop unnecessary SignupService methods #480

rename
654d33d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 14, 2024 in 0s

85.93% (-0.07%) compared to c2644e1

View this Pull Request on Codecov

85.93% (-0.07%) compared to c2644e1

Details

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.93%. Comparing base (c2644e1) to head (654d33d).

Files with missing lines Patch % Lines
pkg/signup/service/signup_service.go 33.33% 1 Missing and 1 partial ⚠️
pkg/verification/service/verification_service.go 33.33% 0 Missing and 2 partials ⚠️
pkg/proxy/handlers/spacelister.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
- Coverage   85.99%   85.93%   -0.07%     
==========================================
  Files          32       32              
  Lines        2499     2488      -11     
==========================================
- Hits         2149     2138      -11     
  Misses        265      265              
  Partials       85       85

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov