drop unnecessary SignupService methods

[MatousJobanek]

drops GetSignupFromInformer method as there is no informer anymore, and use GetSignup method instead
drops UpdateUserSignup as we can call the update directly on the client
KUBESAW-198

[alexeykazakov]

Flaky metric test? host-operator-metrics-service failed to start.

/retest

[ranakan19]

looks good

[codecov]

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.93%. Comparing base (c2644e1) to head (654d33d).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/signup/service/signup_service.go	33.33%	1 Missing and 1 partial ⚠️
pkg/verification/service/verification_service.go	33.33%	0 Missing and 2 partials ⚠️
pkg/proxy/handlers/spacelister.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
- Coverage   85.99%   85.93%   -0.07%     
==========================================
  Files          32       32              
  Lines        2499     2488      -11     
==========================================
- Hits         2149     2138      -11     
  Misses        265      265              
  Partials       85       85              

Flag	Coverage Δ
unittests	85.93% <54.54%> (-0.07%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
3.6% Duplication on New Code

See analysis details on SonarCloud

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MatousJobanek, ranakan19, xcoulon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MatousJobanek,alexeykazakov,ranakan19,xcoulon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment