Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add disable inheritance api #927

Conversation

mmulholla
Copy link
Contributor

For api change in codeready-toolchain/api#386

@openshift-ci openshift-ci bot added the approved label Nov 8, 2023
Copy link

openshift-ci bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, mfrancisc, mmulholla, rajivnathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmulholla
Copy link
Contributor Author

Can I get a "lgtm" label please?

Copy link

sonarcloud bot commented Nov 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.3% 4.3% Duplication

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #927 (d680c64) into master (0c00045) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #927      +/-   ##
==========================================
- Coverage   83.62%   83.61%   -0.02%     
==========================================
  Files          53       53              
  Lines        6145     6145              
==========================================
- Hits         5139     5138       -1     
- Misses        821      822       +1     
  Partials      185      185              

see 1 file with indirect coverage changes

@alexeykazakov alexeykazakov merged commit cdedd1b into codeready-toolchain:master Nov 10, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants