-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add disableInheritance for Spaces and SpaceRequests #386
add disableInheritance for Spaces and SpaceRequests #386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good but please create separate PR for the host operator repo just to update the CRD.
This is how we usually introduce API changes:
- Change the API and generate the CRDs in the corresponding operator repos locally.
- Create an API PR and PRs for the corresponding operators repos with the updated CRDs.
- Get all of those PRs merged.
- Now you can create PRs which actually use the new API.
See an example of the first step here: Create webhook secret #385
PR codeready-toolchain/host-operator#927 created with just results from make generate. |
also one for member-operator: codeready-toolchain/member-operator#500 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure there is no changes in api/v1alpha1/zz_generated.deepcopy.go
when you do make generate
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
As Alexey mentioned you should have changes to api/v1alpha1/zz_generated.openapi.go
, I just double checked locally.
440bb36
to
ea1ae26
Compare
Kudos, SonarCloud Quality Gate passed!
|
I have added the file. Thx for the heads-up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Thanks!
Sure |
Description
Add disableInheritance flag to Space and SpaceRequest
see: https://issues.redhat.com/browse/ASC-428
Checks
Did you run
make generate
target? yes/noDid
make generate
change anything in other projects (host-operator, member-operator)? yesIn case of new CRD, did you the following? no
resources/setup/roles/host.yaml
in the sandbox-sre repositoryPROJECT
file: https://github.com/codeready-toolchain/host-operator/blob/master/PROJECTCSV
file: https://github.com/codeready-toolchain/host-operator/blob/master/config/manifests/bases/host-operator.clusterserviceversion.yamlIn case other projects are changed, please provides PR links.