Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allocating correct amount of Local memory in Global Implementation #128

Merged
merged 7 commits into from
Jan 4, 2024
Merged

Allocating correct amount of Local memory in Global Implementation #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e573c35
add padding when assigning local memory in compute_level
AD2605 Jan 3, 2024
232b795
Merge remote-tracking branch 'origin/main' into atharva/oob_access_bu…
AD2605 Jan 3, 2024
c36f074
removed added size 15360
AD2605 Jan 3, 2024
4e61eb5
added 9800 and 68640 in regression test suite
AD2605 Jan 3, 2024
3046a39
remove 68640 from regression test
AD2605 Jan 3, 2024
ee22fd1
remove repeated 9800 test
AD2605 Jan 3, 2024
5f36ace
removed duplicate 68640
AD2605 Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/portfft/common/global.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@ std::vector<sycl::event> compute_level(
return 1;
}
if (kd_struct.level == detail::level::SUBGROUP) {
return 2 * kd_struct.length * static_cast<std::size_t>(local_range / 2);
return detail::pad_local(2 * kd_struct.length * static_cast<std::size_t>(local_range / 2), std::size_t(1));
Rbiessy marked this conversation as resolved.
Show resolved Hide resolved
}
}
return std::size_t(1);
Expand Down
6 changes: 6 additions & 0 deletions test/unit_test/instantiate_fft_tests.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,12 @@ INSTANTIATE_TEST_SUITE_P(GlobalTest, FFTTest,
::testing::Values(sizes_t{32768}, sizes_t{65536}, sizes_t{131072}))),
test_params_print());

INSTANTIATE_TEST_SUITE_P(WorkgroupOrGlobalRegressionTest, FFTTest,
::testing::ConvertGenerator<basic_param_tuple>(
::testing::Combine(ip_packed_layout, fwd_only, interleaved_storage, ::testing::Values(3),
::testing::Values(sizes_t{9800}))),
test_params_print());

// Backward FFT test suite
INSTANTIATE_TEST_SUITE_P(BackwardTest, FFTTest,
::testing::ConvertGenerator<basic_param_tuple>(::testing::Combine(
Expand Down