Allocating correct amount of Local memory in Global Implementation #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjabird
previously approved these changes
Jan 3, 2024
t4c1
previously approved these changes
Jan 3, 2024
Rbiessy
reviewed
Jan 3, 2024
t4c1
previously approved these changes
Jan 4, 2024
Rbiessy
approved these changes
Jan 4, 2024
t4c1
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In global.hpp, on line 473, it has not been taken into consideration that the local memory for modifiers is, in-fact padded, and only allocates non padded amount of local memory.
After this fix, all tests on the opencl backend passes(at least locally !), and even fixes the issue with sizes 9800 and
68640on SPIR-V backendBorrows regression test suite from #127
Checklist
Tick if relevant: