[CRDB-44987] lint: upgrade helmpack/chart-testing #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version v3.3.1 of helmpack/chart-testing is 4 years old and comes bundled with older version of Helm wtih limited feature set. Upgrade to the latest v3.11.0 (7 months old).
pritesh-lahoti
commented
Nov 28, 2024
| @@ -2,4 +2,4 @@ | |||
|
|
|||
| set -euox pipefail | |||
|
|
|||
| build/tester.sh ct lint --config build/ct.yaml --all | |||
| build/tester.sh ct lint --config build/ct.yaml --all --validate-maintainers=false | |||
There was a problem hiding this comment.
Without this, was hitting the below error:
Validating maintainers...
------------------------------------------------------------------------------------------------------------------------
✖︎ cockroachdb => (version: "14.0.5", path: "cockroachdb") > could not parse git repository domain for "origin"
------------------------------------------------------------------------------------------------------------------------
Error: failed linting charts: failed processing charts
failed linting charts: failed processing charts
make: *** [test/lint] Error 1
The issue helm/chart-testing#464 captures the discussion around the resolution of this error. I did not find validating maintainers as a necessary thing, hence choosing to skip the same. Open to thoughts.
There was a problem hiding this comment.
I agree skipping this check is better than adding some wrapper on chart-testing.
prafull01
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version v3.3.1 of helmpack/chart-testing is 4 years old and comes bundled with older version of Helm wtih limited feature set. Upgrade to the latest v3.11.0 (7 months old).