Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRDB-44987] lint: upgrade helmpack/chart-testing #431

Merged
merged 1 commit into from
Dec 2, 2024
Merged

[CRDB-44987] lint: upgrade helmpack/chart-testing #431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/lint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

set -euox pipefail

build/tester.sh ct lint --config build/ct.yaml --all
build/tester.sh ct lint --config build/ct.yaml --all --validate-maintainers=false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this, was hitting the below error:

Validating maintainers...

------------------------------------------------------------------------------------------------------------------------
 ✖︎ cockroachdb => (version: "14.0.5", path: "cockroachdb") > could not parse git repository domain for "origin"
------------------------------------------------------------------------------------------------------------------------
Error: failed linting charts: failed processing charts
failed linting charts: failed processing charts
make: *** [test/lint] Error 1

The issue helm/chart-testing#464 captures the discussion around the resolution of this error. I did not find validating maintainers as a necessary thing, hence choosing to skip the same. Open to thoughts.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree skipping this check is better than adding some wrapper on chart-testing.

2 changes: 1 addition & 1 deletion build/tester.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
set -euo pipefail

image="quay.io/helmpack/chart-testing"
version="v3.3.1"
version="v3.11.0"

if [ "${1-}" = "pull" ]; then
docker pull "${image}:${version}"
Expand Down