Makefile: Update Cockpit lib to 3b1a41701581de0ed6826191b6d72e83 #1894
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
changed the title
allisonkarlitskaya
force-pushed
the
cockpit-lib-update-cockpit-lib-20241104-183546
branch
from
b7679fa
to
4a1ca3f
Compare
|
This needs adjustment to the newly ported TypeaheadSelect. |
Yup, already started locally. 1/X tests fixed :) |
This does not make a lot of sense as it will show no such file or directory. Only set it when we have a valid location to set.
jelly
force-pushed
the
cockpit-lib-update-cockpit-lib-20241104-183546
branch
from
4a1ca3f
to
864a16d
Compare
|
Firefox specific issues left |
jelly
force-pushed
the
cockpit-lib-update-cockpit-lib-20241104-183546
branch
from
080550a
to
124f66b
Compare
The FileAutoComplete component now uses a non-deprecated Select which has a different internal DOM state. The create text was also adjusted to no longer quote the path.
Instead of asserting it exists, validate that the correct text is shown.
jelly
force-pushed
the
cockpit-lib-update-cockpit-lib-20241104-183546
branch
from
7a9e642
to
98e6471
Compare
|
The centos-10 coredump here is the same as what blocks are gating and needs to be investigated |
There was a problem hiding this comment.
Thanks!
This pixel change is a bit sad -- we now have two different "X" buttons in inputs in the same dialog. Can we port the "operating system" one as well?
That is what Marius intended to work on but it needs further enhancements of the Typeahead to support grouping? This one: |
|
Thanks! |
Jelle van der Waa (2):
test: restore fstab/crypttab for RHEL 8 storage tests
lib: restrict SASS plugin to scss files
Marius Vollmer (9):
lib: Copy TypeaheadSelect into our code
lib: Fix TypeScript error in TypeaheadSelect
lib: Optionally trust selected property in TypeaheadSelect
lib: Support dividers with TypeaheadSelect
lib: Hide clear button in TypeaheadSelect when it would do nothing
lib: Simplify and translate UI texts in TypeaheadSelect
storage: Use TypeaheadSelect instead of deprecated Select
lib: Use TypeaheadSelect instead of deprecated Select for timezones
lib: Use TypeaheadSelect instead of deprecated Select for FileAutoComplete
Martin Pitt (3):
lib: Properly type getLastlog2
lib: Add typing for cockpit.jump() and cockpit.dbus().call()
lib: Initial typing of python.js