Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: Update Cockpit lib to 3b1a41701581de0ed6826191b6d72e83 #1894

Merged
merged 5 commits into from
Nov 8, 2024
Merged

Makefile: Update Cockpit lib to 3b1a41701581de0ed6826191b6d72e83 #1894

merged 5 commits into from
Nov 8, 2024

Commits on Nov 6, 2024

  1. Makefile: Update Cockpit lib to 3b1a41701581de0ed6826191b6d72e83 

    Closes #1894
    @cockpituous @jelly
    cockpituous authored and jelly committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    1d60ad3 View commit details
    Browse the repository at this point in the history

  2. test: don't set the file input component to " " 

    This does not make a lot of sense as it will show no such file or
directory. Only set it when we have a valid location to set.
    @jelly
    jelly committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    9d32ec4 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. test: adjust tests for new FileAutoComplete 

    The FileAutoComplete component now uses a non-deprecated Select which
has a different internal DOM state.

The create text was also adjusted to no longer quote the path.
    @jelly
    jelly committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    4460b59 View commit details
    Browse the repository at this point in the history

  2. test: update pixel tests for new FileAutoComplete component

    @jelly
    jelly committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    c3bf2d7 View commit details
    Browse the repository at this point in the history

  3. test: validate the actual helpertext text 

    Instead of asserting it exists, validate that the correct text is shown.
    @jelly
    jelly committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    98e6471 View commit details
    Browse the repository at this point in the history