Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port Jingjing's backcasting preprocessing utils #114

Draft
wants to merge 19 commits into
base: dev
Choose a base branch
from
Draft

Port Jingjing's backcasting preprocessing utils #114

wants to merge 19 commits into from

Commits on Jun 14, 2022

  1. Copy over parts of Jingjing's backcaster preprocessing utilities 

    Modified-by: Logan C. Brooks <[email protected]>
    @jingjtang @lcbrooks
    jingjtang authored and lcbrooks committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    b0a5859 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2022

  1. Fix roxygen issues, testthat ed3 complaint, missing ref_lag global

    @lcbrooks
    lcbrooks committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    f5847ba View commit details
    Browse the repository at this point in the history

  2. Add missed definition of n_refds

    @jingjtang @lcbrooks
    jingjtang authored and lcbrooks committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    00ea36c View commit details
    Browse the repository at this point in the history

  3. Fix an error in the unit test

    @jingjtang @lcbrooks
    jingjtang authored and lcbrooks committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    a949301 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Refactor ref_lag from global to params, get tests working 

    Get lag-completion/target-lag function tests working in package setting. Before
this change, `ref_lag` was a global set in a not-yet-package file and also the
test file, which, when converted into a package, did not pass tests, as the
tests' `ref_lag` global doesn't overwrite the pre-existing value from the
package.
    @lcbrooks
    lcbrooks committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    ee46dab View commit details
    Browse the repository at this point in the history

  2. Improve names of backcasting preprocessing preprocessing files

    @lcbrooks
    lcbrooks committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    74cceb5 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2022

  1. swap Abort in for stop

    @nmdefries
    nmdefries committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    462552c View commit details
    Browse the repository at this point in the history

  2. .Rd re-documented

    @nmdefries
    nmdefries committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    c142eae View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2022

  1. clarify docs, package imports

    @nmdefries
    nmdefries committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    ea4261c View commit details
    Browse the repository at this point in the history

  2. import zoo

    @nmdefries
    nmdefries committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    2c14536 View commit details
    Browse the repository at this point in the history

  3. dplyr-ize field renaming

    @nmdefries
    nmdefries committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    7f06c03 View commit details
    Browse the repository at this point in the history

  4. allow any name for value field 

    `add_7davs_and_target` used to rename `value_raw` to `value_target`
regardless of what the parameter `value_col` is set to. This causes an
error when `value_raw` can't be found in a df with a differently-name
value column.
    @nmdefries
    nmdefries committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    b1026a1 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2022

  1. Merge branch 'main' into lcb/port-jingjing-backcasting-preprocessing-… 

    …utils
    @nmdefries
    nmdefries committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    20016b5 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2022

  1. remove unneeded jsonlite load

    @nmdefries
    nmdefries committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    958c6a9 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2022

  1. support using implied lag col

    @nmdefries
    nmdefries committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    6935ec8 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2022

  1. allow user to specify issue date col name

    @nmdefries
    nmdefries committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    66cb491 View commit details
    Browse the repository at this point in the history

  2. test implied lag/issue date behavior

    @nmdefries
    nmdefries committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    41eb9ed View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. formatting

    @nmdefries
    nmdefries committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    c3e3aa4 View commit details
    Browse the repository at this point in the history

  2. allow any name for value field

    @nmdefries
    nmdefries committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    11e643c View commit details
    Browse the repository at this point in the history