-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Jingjing's backcasting preprocessing utils #114
Draft
brookslogan
wants to merge
19
commits into
dev
Choose a base branch
from
lcb/port-jingjing-backcasting-preprocessing-utils
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Port Jingjing's backcasting preprocessing utils #114
brookslogan
wants to merge
19
commits into
dev
from
lcb/port-jingjing-backcasting-preprocessing-utils
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified-by: Logan C. Brooks <[email protected]>
Get lag-completion/target-lag function tests working in package setting. Before this change, `ref_lag` was a global set in a not-yet-package file and also the test file, which, when converted into a package, did not pass tests, as the tests' `ref_lag` global doesn't overwrite the pre-existing value from the package.
brookslogan
changed the title
Lcb/port jingjing backcasting preprocessing utils
Port Jingjing's backcasting preprocessing utils
Jun 21, 2022
`add_7davs_and_target` used to rename `value_raw` to `value_target` regardless of what the parameter `value_col` is set to. This causes an error when `value_raw` can't be found in a df with a differently-name value column.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #88. Might involve #49, #90, #106, #109.
Progress so far:
Some TODOs:
epiprocess
classes (taking care that current functions work on a single geo/epigroup at a time)version - time_value
or an explicit lag/lag-like column.Check that, or change to: either always, or optionally, add NAs getting/filling lag training data if it looks like we missed recording a version (it's okay if there is no update for an observation in a target version, but a problem if there are no updates for any observations in a target version)unless there are bugs from assuming that versions are evenly spaced, this is a separate convenience function/arg to think about independentlyfill_rows
andfill_missing_updates
to use a mix of last-version-carried-forward and NA/0/customizable fill-in determined by archive's [check out $fill_through_version --- may or may not be useful]Abort
, etc., rather thanstop
epix_slide
. Straightforward is probably combining with Shouldslide()
forepi_archive
be given access to less than the most up-to-date snapshots? #49. But we might also think about turning the time&version-lag covariates dfs into a custom type of epi_archive (base epi_archive would be pretty inefficient though; lazy merge might be one way to improve). ------ Just do the straightforward way to begin with, then profile.