-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chart): Create initial Chart for csi-cloudscale #43
Conversation
Signed-off-by: Toni Tauro <[email protected]>
Signed-off-by: Toni Tauro <[email protected]>
Hi @eyenx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi again!
I had a more in-depth look into your pull request. Thanks, again, for your contribution. I think publishing the chart is definitely an option for the future.
I have added a number of comments to your code, where the release generated by the chart differs from the current YAML. Some of them seem to be typos, etc., whereas for others I am uncertain if they were intentional.
Additionally, I think we should set up a Helm chart repo and set up GitHub actions to publish the chart to it.
If you add to the PR, I'll have a look again. Otherwise, I'll probably try to finish it in a few weeks.
Signed-off-by: Toni Tauro <[email protected]>
146f661
to
71a5e47
Compare
Setting this up needs elevate admin rights to the repository. Feel free to check out our github actions and how we publish charts on https://github.com/adfinis-sygroup/helm-charts |
@alain One more thing: If we merge this, I think we should strongly consider generating the static manifests by the helm charts for each release, because having two separate deployment sets (with almost the same content) is probably a bad idea. Not sure how people are doing this, though. |
I had this on my mind as well. |
* Generate static yaml from helm.
* Fix some things releated to kubepsray.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall. I've left some suggestions for improvements inline.
We'll be able to switch to the Helm chart without any big issues (see also projectsyn/component-csi-cloudscale#47)
a82b55a
to
fcc1661
Compare
…enerating YAML manifests).
make NEW_VERSION=v3.3.0 bump-version make NEW_CHART_VERSION=v1.0.0 bump-chart-version
Creates a first initial draft of a helm chart for easily deploying csi-cloudscale via helm
Signed-off-by: Toni Tauro [email protected]