Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update main.tf #115

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update main.tf #115

wants to merge 5 commits into from

Conversation

oscarmendoza123
Copy link

@oscarmendoza123 oscarmendoza123 commented Jun 6, 2024 •
edited
Loading

what

If you are using var.findings_notification_arn then you still want the IAM role to be allowed to publish to the SNS topic.

why

This module should support the IAM role to publish to an imported SNS topic. The logic is already handled by local. enable_notifications.

enable_notifications = module.this.enabled && (var.create_sns_topic || var.findings_notification_arn != null)

references

@oscarmendoza123 oscarmendoza123 requested review from a team as code owners June 6, 2024 14:53
@mergify mergify bot added the triage Needs triage label Jun 6, 2024
@oscarmendoza123
Copy link
Author

Anything I need to do here to get this merged in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hans-d hans-d Awaiting requested review from hans-d hans-d is a code owner automatically assigned from cloudposse/contributors

@jamengual jamengual Awaiting requested review from jamengual jamengual is a code owner automatically assigned from cloudposse/contributors

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
triage Needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oscarmendoza123