Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date/time JSON and files management #94

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

pihart
Copy link
Collaborator

@pihart pihart commented Nov 14, 2020

  • Save export date/time in json (give it a new version number)
  • Refactor pages.ts by moving operations to files.ts
  • Refactor jsonwriter
  • Refactor timestring method

fileURL,
revokeURL
);
};
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should actually return an object of a new type FileUIDownloader with the data

{
  name: `qboard-${FileUI.timeStringNow()}.json`,
  fileURL,
  revokeURL,
}

Then FileUI::download should accept an object of this type, and any function calling JSONWriter::download should take the result and call its own FileUI::download. I'd probably rename JSONWriter::download to JSONWriter::getDownloader.

(I use the :: syntax to denote instance methods.)

@pihart pihart marked this pull request as draft March 16, 2021 04:12
@pihart pihart mentioned this pull request Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save datetime in JSON
1 participant