Clean up save to json, improve JSONWriter #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pihart
commented
Dec 14, 2020
•
pihart
commented
- Move file downloading procedure from Pages > safeFile() to JSONWriter > download()
- Improve caching in JSONWriter
in addition to stringified Don't generate new object url and waste memory if it hasn't yet been revoked. Slight difference in behavior: the revoke function outputted from toURL is always the same thing. it revokes whatever the current url is; not the url that was outputted with the revoke function.
pihart
changed the title
|
so apparently i already did some of this in #94 |
cjquines
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.