Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ent param init #58

Merged
merged 9 commits into from
Nov 8, 2024
Merged

Ent param init #58

merged 9 commits into from
Nov 8, 2024

Conversation

stroblme
Copy link
Member

@stroblme stroblme commented Nov 6, 2024

This PR fixes how n_samples is being treated in the meyer_wallach method.
If the parameter is None or <1, then the model internal parameters are being used.
This required setting the model internal parameters in each forward call.

Melvin Strobl added 3 commits November 6, 2024 15:59
fixed how n_samples affects params
12b7ec2 
Signed-off-by: Melvin Strobl <[email protected]>
docs
e2dac34 
Signed-off-by: Melvin Strobl <[email protected]>
updating model parameters
8f7bc9e 
Signed-off-by: Melvin Strobl <[email protected]>
@pep8speaks
Copy link

pep8speaks commented Nov 6, 2024 •
edited
Loading

Hello @stroblme! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-11-08 13:16:51 UTC

Melvin Strobl added 3 commits November 6, 2024 16:12
qa
a15f12d 
Signed-off-by: Melvin Strobl <[email protected]>
updated docstring
ce239cb 
Signed-off-by: Melvin Strobl <[email protected]>
added test
73bbfec 
Signed-off-by: Melvin Strobl <[email protected]>
@stroblme
Copy link
Member Author

stroblme commented Nov 6, 2024 •
edited
Loading

  • resolve problem of ArrayBox elements: when using inside an optimisation loop, params become an arraybox which cannot be treated as a numpy array

fixed arraybox issues
019b88a 
Signed-off-by: Melvin Strobl <[email protected]>
catching none
335ec6c 
Signed-off-by: Melvin Strobl <[email protected]>
majafranz
majafranz approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@majafranz majafranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

bumped version
57a03a2 
Signed-off-by: Melvin Strobl <[email protected]>
@stroblme stroblme merged commit 3fc704b into main Nov 8, 2024
4 checks passed
@stroblme stroblme deleted the ent_param_init branch November 8, 2024 13:40
@stroblme stroblme mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majafranz majafranz majafranz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stroblme @pep8speaks @majafranz