Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustable frequencies #44

Merged
merged 15 commits into from
Nov 12, 2024
Merged

Adjustable frequencies #44

merged 15 commits into from
Nov 12, 2024

Conversation

stroblme
Copy link
Member

This PR (partially) resolves #14 by introducing adjustable number of frequencies.
I did not found a convenient way to adjust all the amplitudes individually, but I think it's good to go with just the # of freqs.
Also we can now adjust the stepsize (because for higher # freqs., learning is tricky..).

Depends on #42

Melvin Strobl added 12 commits November 6, 2024 11:50
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
gc
Signed-off-by: Melvin Strobl <[email protected]>
qa
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
@pep8speaks
Copy link

pep8speaks commented Nov 11, 2024

Hello @stroblme! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 146:89: E501 line too long (94 > 88 characters)
Line 204:89: E501 line too long (97 > 88 characters)
Line 457:89: E501 line too long (89 > 88 characters)

Comment last updated at 2024-11-12 13:11:37 UTC

@stroblme
Copy link
Member Author

Hello @stroblme! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

* In the file [`app/pages/1-training.py`](https://github.com/cirKITers/mind-the-qapp/blob/425d66681c59de73d8bd7f682d40ac85b1d33eec/app/pages/1-training.py):

Line 146:89: E501 line too long (94 > 88 characters)
Line 204:89: E501 line too long (97 > 88 characters)
Line 457:89: E501 line too long (89 > 88 characters)

ignore, we will tackle that with #45

@stroblme stroblme mentioned this pull request Nov 11, 2024
Melvin Strobl added 3 commits November 11, 2024 17:30
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Copy link
Collaborator

@majafranz majafranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Nice realisation of the issue!

@majafranz majafranz merged commit 6cb31e3 into main Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Option to adjust frequencies and their amplitudes
3 participants