Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Export HTML code to external files and add #NOQA for those #38

Closed
stroblme opened this issue Nov 6, 2024 · 1 comment · Fixed by #45
Closed

[FR] Export HTML code to external files and add #NOQA for those #38

stroblme opened this issue Nov 6, 2024 · 1 comment · Fixed by #45
Labels
enhancement New feature or request

Comments

@stroblme
Copy link
Member

stroblme commented Nov 6, 2024

Is your feature request related to a problem? Please describe.
Currently we get complains by flake that our html code exceeds line length. However, there exist no better way of dealing with this as it is still readable but due to the structure of html naturally gets quite lengthy.

Describe the solution you'd like
Move the layout code to an separate python file and import it in the corresponding page. Then ignore those external files in the flake config, so that we get proper QA for the "functional" code and skip QA for the "structural" one.

Describe alternatives you've considered
Open to other suggestions..

Additional context
N/A

@stroblme stroblme added the enhancement New feature or request label Nov 6, 2024
This was referenced Nov 6, 2024
Merged
@stroblme
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant