Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qml essentials 16 #34

Merged
merged 20 commits into from
Nov 8, 2024
Merged

Qml essentials 16 #34

merged 20 commits into from
Nov 8, 2024

Conversation

stroblme
Copy link
Member

@stroblme stroblme commented Nov 6, 2024

This PR adds the latest qml essentials package and resolves #25

  • switch to entanglement calculation from qml essentials
  • switch to expressibility calculation from qml essentials

Melvin Strobl added 13 commits October 22, 2024 11:52
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
@pep8speaks
Copy link

pep8speaks commented Nov 6, 2024

Hello @stroblme! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 54:89: E501 line too long (92 > 88 characters)

Line 87:21: E203 whitespace before ':'
Line 87:78: E203 whitespace before ':'

Comment last updated at 2024-11-08 14:35:35 UTC

Melvin Strobl added 4 commits November 6, 2024 10:30
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
qa
Signed-off-by: Melvin Strobl <[email protected]>
@stroblme
Copy link
Member Author

stroblme commented Nov 6, 2024

not sure why flake refuses to ignore E203.. anyway, E501 should be treated in the corresponding issue #38

Copy link
Collaborator

@majafranz majafranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Great work, Thanks!

@stroblme
Copy link
Member Author

stroblme commented Nov 6, 2024

expressibility is not quite working yet..

@majafranz
Copy link
Collaborator

majafranz commented Nov 7, 2024

  • update to qml-essentials 0.1.16, once released

@stroblme stroblme changed the title Qml essentials 15 Qml essentials 16 Nov 8, 2024
Melvin Strobl and others added 2 commits November 8, 2024 14:49
@majafranz
Copy link
Collaborator

Expressibility should work now, as well

@stroblme
Copy link
Member Author

stroblme commented Nov 8, 2024

awesome, thanks!
I'm sometimes getting an error when calculating entanglement, but I'll move that to #39

@stroblme stroblme merged commit 43111c4 into main Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Merge with Expressiblity, Entangling Capability and Coefficients from QML Essentials
3 participants