Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync figures #42

Merged
merged 9 commits into from
Nov 12, 2024
Merged

Sync figures #42

merged 9 commits into from
Nov 12, 2024

Conversation

stroblme
Copy link
Member

@stroblme stroblme commented Nov 11, 2024

This PR resolves #37
Also, presumably, this resolves #39 and resolves #35 as I was not able to reproduce it (so far). Please check on that @majafranz

Depends on #40

Melvin Strobl added 7 commits November 6, 2024 11:50
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
gc
Signed-off-by: Melvin Strobl <[email protected]>
qa
Signed-off-by: Melvin Strobl <[email protected]>
@pep8speaks
Copy link

pep8speaks commented Nov 11, 2024

Hello @stroblme! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 390:89: E501 line too long (89 > 88 characters)

Comment last updated at 2024-11-11 12:04:15 UTC

Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
@stroblme stroblme mentioned this pull request Nov 11, 2024
Copy link
Collaborator

@majafranz majafranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@majafranz majafranz merged commit a55555b into main Nov 12, 2024
@majafranz majafranz deleted the sync-figures branch November 12, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] pop from empty list [BUG] Sync between figures [BUG] "No data left in file" error appears randomly
3 participants