-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ruby to 3.3 #233
base: main
Are you sure you want to change the base?
Upgrade ruby to 3.3 #233
Changes from all commits
e3cf754
8cc13df
bdf98e6
e4ee19d
2547dbd
02c6928
c0877b4
0839e8e
44ffb25
7b859e9
fd2f091
50d5f0e
85104aa
70650c8
5677e3a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,7 +29,7 @@ Gem::Specification.new do |gem| | |
gem.license = "Apache-2.0" | ||
gem.homepage = "https://www.chef.io/" | ||
|
||
gem.required_ruby_version = ">= 2.7" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We are still releasing at least one last bug fix release for Chef 17, and therefore would have Ruby 3.0.x on that version |
||
gem.required_ruby_version = ">= 3.3" | ||
|
||
gem.files = %w{Rakefile LICENSE} + | ||
Dir.glob("Gemfile*") + # Includes Gemfile and locks | ||
|
@@ -43,7 +43,7 @@ Gem::Specification.new do |gem| | |
gem.add_dependency "mixlib-shellout", ">= 2.0", "< 4.0" | ||
gem.add_dependency "ffi-yajl", ">= 1.0", "< 3.0" | ||
gem.add_dependency "minitar", "~> 0.6" | ||
if RUBY_VERSION.match?(/3.1/) | ||
if RUBY_VERSION.match?(/3.3/) | ||
gem.add_dependency "chef", "~> 18.0" | ||
else | ||
gem.add_dependency "chef", "~> 17.0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Given that the |
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we still need Ruby 3.0 and Ruby 3.1 tests passing until Chef 17 and 18 (respectively) are EOL.