Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ruby to 3.3 #233

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Upgrade ruby to 3.3 #233

wants to merge 15 commits into from

Conversation

nikhil2611
Copy link
Contributor

@nikhil2611 nikhil2611 commented Jul 10, 2024 •
edited
Loading

Description

Added verify pipeline for ruby 3.3

Related Issue

https://chefio.atlassian.net/browse/CHEF-12434

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@github-actions GitHub Actions
Copy link

Simplecov Report

Covered Threshold
98.51% 90%

@nikhil2611 nikhil2611 requested review from a team as code owners July 10, 2024 11:27
nikhil2611 added 10 commits July 11, 2024 17:24
@nikhil2611
fixing test-cases
02c6928 
Signed-off-by: nikhil2611 <[email protected]>
@nikhil2611
updated gem versions
c0877b4 
Signed-off-by: nikhil2611 <[email protected]>
@nikhil2611
typ
0839e8e 
Signed-off-by: nikhil2611 <[email protected]>
@nikhil2611
added win ruby 3.1 pipeline
44ffb25 
Signed-off-by: nikhil2611 <[email protected]>
@nikhil2611
updated test cases
7b859e9 
Signed-off-by: nikhil2611 <[email protected]>
@nikhil2611
removed extra spaces
fd2f091 
Signed-off-by: nikhil2611 <[email protected]>
@nikhil2611
updated rspec version
50d5f0e 
Signed-off-by: nikhil2611 <[email protected]>
@nikhil2611
updated test data
85104aa 
Signed-off-by: nikhil2611 <[email protected]>
@nikhil2611
updated the unit.yml to 3.3
70650c8 
Signed-off-by: nikhil2611 <[email protected]>
@nikhil2611
updated the ruby to 3.3 in gemspec
5677e3a 
Signed-off-by: nikhil2611 <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
10.5% Duplication on New Code

See analysis details on SonarCloud

@sonarqube-for-infrastructure-prod SonarQube for Infrastructure (Prod)
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
10.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube

tpowell-progress
tpowell-progress suggested changes Aug 6, 2024
View reviewed changes
Copy link

@tpowell-progress tpowell-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruby 3.0 minimum

chef-cli.gemspec
@@ -43,7 +43,7 @@ Gem::Specification.new do |gem|
gem.add_dependency "mixlib-shellout", ">= 2.0", "< 4.0"
gem.add_dependency "ffi-yajl", ">= 1.0", "< 3.0"
gem.add_dependency "minitar", "~> 0.6"
if RUBY_VERSION.match?(/3.1/)
if RUBY_VERSION.match?(/3.3/)
gem.add_dependency "chef", "~> 18.0"
else
gem.add_dependency "chef", "~> 17.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the required_ruby_version is ">= 3.3", this would seem to indicate that if you have Ruby 3.4 installed, that you'll be locked to Chef 17, which I'm not sure will work out.

chef-cli.gemspec
@@ -29,7 +29,7 @@ Gem::Specification.new do |gem|
gem.license = "Apache-2.0"
gem.homepage = "https://www.chef.io/"

gem.required_ruby_version = ">= 2.7"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are still releasing at least one last bug fix release for Chef 17, and therefore would have Ruby 3.0.x on that version

.expeditor/verify.pipeline.yml

- label: run-specs-ruby-3.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need Ruby 3.0 and Ruby 3.1 tests passing until Chef 17 and 18 (respectively) are EOL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpowell-progress tpowell-progress tpowell-progress requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikhil2611 @tpowell-progress