-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(www): update graphql starter documentation to reflect graphql_co… #597
Merged
JohnAlbin
merged 4 commits into
chapter-three:main
from
cruno91:docs-graphql-starter-updates
Feb 20, 2024
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
fb0d968
docs(www): update graphql starter documentation to reflect graphql_co…
cruno91 38dbd19
Merge branch 'main' into docs-graphql-starter-updates
cruno91 72c6a1b
docs: update list of graphql compose modules needed for graphql example
cruno91 d50a184
Merge branch 'main' into docs-graphql-starter-updates
JohnAlbin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Edge Query" is not an option unless "GraphQL Compose: Edges" is enabled, which the instructions do not indicate we need to do.
"Loading by Route" is not an option unless "GraphQL Compose: Routes" is enabled, which the instructions do not indicate we need to do.
So… we need to update the step above "2. Enable the following modules" to include those 2 modules. Are there other modules that should also be enabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I forgot the module was split up a bit between beta and 2.x releases. I'll try to get a commit in for this this week if I can clear some time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JohnAlbin it took a while for me to get back to it, but I've updated the list of modules for the GrpahQL example docs.
For the GraphQL example it doesn't look like there aren't any other modules which need to be manually enabled. Everything else should be enabled as dependencies of the current list.