Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(www): update graphql starter documentation to reflect graphql_co… #597

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

cruno91
Copy link
Contributor

@cruno91 cruno91 commented Nov 17, 2023

…mpose 2.0.0 and graphql 4.6.0

This pull request is for: (mark with an "x")

  • examples/*
  • modules/next
  • packages/next-drupal
  • starters/basic-starter
  • starters/graphql-starter
  • [x ] Other

GitHub Issue: #596

  • [ x] I need help adding tests. (mark with an "x")

Describe your changes

Updated the docs to reflect updated patches for drupal/subrequests & drupal/decoupled_router and the changes in how drupal/graphql_compose is configured in version 2.0.0.

Copy link

vercel bot commented Nov 17, 2023

@cruno91 is attempting to deploy a commit to the Chapter Three Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@JohnAlbin JohnAlbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good! But I noticed the "Enable the following modules" step also needs updating.

## Configure GraphQL Compose

1. Visit `/admin/config/graphql_compose`.
2. Enable "GraphQL", "Single Query", "Edge Query", & "Loading by Route" for the Article content type.
Copy link
Collaborator

@JohnAlbin JohnAlbin Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Edge Query" is not an option unless "GraphQL Compose: Edges" is enabled, which the instructions do not indicate we need to do.

"Loading by Route" is not an option unless "GraphQL Compose: Routes" is enabled, which the instructions do not indicate we need to do.

So… we need to update the step above "2. Enable the following modules" to include those 2 modules. Are there other modules that should also be enabled?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I forgot the module was split up a bit between beta and 2.x releases. I'll try to get a commit in for this this week if I can clear some time.

Copy link
Contributor Author

@cruno91 cruno91 Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JohnAlbin it took a while for me to get back to it, but I've updated the list of modules for the GrpahQL example docs.

For the GraphQL example it doesn't look like there aren't any other modules which need to be manually enabled. Everything else should be enabled as dependencies of the current list.

@cruno91 cruno91 requested a review from JohnAlbin January 24, 2024 03:36
@JohnAlbin JohnAlbin merged commit 2b7f07f into chapter-three:main Feb 20, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants