-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust moments #46
Merged
Merged
Rust moments #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed -e.
rosecers
reviewed
Sep 3, 2024
rosecers
reviewed
Sep 3, 2024
rosecers
reviewed
Sep 3, 2024
rosecers
reviewed
Sep 3, 2024
rosecers
reviewed
Sep 3, 2024
rosecers
reviewed
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some things that need to be cleaned up, and I'd suggest deleting the rust
folder if the file inside it is no-longer necessary. That was causing some confusion.
But overall looks great!
…le, and added docstrings
rosecers
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An updated version of @YCC-ProjBackups's PR. The code has changed significantly since last year so it's annoying to rebase.
pip install .
setup.py
andsetup.cfg
) in favor of a singlepyproject.toml
file that has been properly configured to compile rust code.One issue is still with the hand-created determinant code, which fails to reproduce the numpy linear algebra code. The workaround isn't too straightforward -- this is either a skill-issue for me, or
numpy-rust
being immature. I wasn't able to getnumpy-rust
to interface withnalgebra
, the main rust linear algebra package.PyReadonlyArray::try_as_matrix
exists to convert types fromnumpy-rust
tonalgebra
, but I couldn't get this to work.