Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small test fixes to bypass warnings #47

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Small test fixes to bypass warnings #47

merged 3 commits into from
Nov 26, 2024

Conversation

rosecers
Copy link
Contributor

@rosecers rosecers commented Sep 3, 2024

Saw some errant warnings when reviewing #46. We generally want to keep these types of warnings to a minimum to avoid output clutter.

arthur-lin1027
arthur-lin1027 reviewed Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@arthur-lin1027 arthur-lin1027 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with these changes to modify the way we generate Atoms to set the cell matrix to be 0.

tests/test_ellipsoidal_density_projection.py Outdated Show resolved Hide resolved
@rosecers rosecers merged commit 25dc3f1 into main Nov 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthur-lin1027 arthur-lin1027 arthur-lin1027 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rosecers @arthur-lin1027