Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use lerna conventional-prerelease for nightlies #3135

Merged

Conversation

smrz2001
Copy link
Contributor

@smrz2001 smrz2001 commented Feb 1, 2024

--canary mode appears to have a bug where it won't update internal dependencies on publish. e.g. If package A (v1) and B (v1) are published and A refers internally to B, then canary mode will publish A => v1.1-nightly.0 and B => v1.1-nightly.0 but A will continue to refer to B => v1 internally.

@smrz2001 smrz2001 requested a review from 3benbox February 1, 2024 16:36
@smrz2001 smrz2001 self-assigned this Feb 1, 2024
Copy link

linear bot commented Feb 1, 2024

Copy link
Contributor

@3benbox 3benbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm plz

@smrz2001
Copy link
Contributor Author

smrz2001 commented Feb 1, 2024

npm plz

You mean npm directly instead of lerna? Lol yes, one day... 😂

@smrz2001 smrz2001 merged commit 56f6526 into develop Feb 1, 2024
10 checks passed
@smrz2001 smrz2001 deleted the feature/ws1-1458-use-nightly-releases-in-ecs-e2e-tests branch February 1, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants