Skip to content

Commit

Permalink
fix: use lerna conventional-prerelease for nightlies (#3135)
Browse files Browse the repository at this point in the history
  • Loading branch information
smrz2001 authored Feb 1, 2024
1 parent 7af80c5 commit 56f6526
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/reusable-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ jobs:
name: Initialize and build code
run: npm ci && npm run build
-
# These step explicitly do not push the release commit so the specified nightly branch will not be impacted
# These steps explicitly do not push the release commit, so the specified nightly branch will not be impacted.
name: Publish all packages to NPM
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
Expand All @@ -317,6 +317,8 @@ jobs:
# and we want to publish nightly packages for the new versions. If this fails, presumably because some
# packages have not changed since the last release, we'll try to publish only the packages that did change.
npm run publish:nightly -- --force-publish --yes
# If we reached here then the publish succeeded and we can exit the workflow
exit 0
continue-on-error: true
-
# Now reset the branch and try to publish only the packages that have changed since the last release
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"publish:release-candidate-followup": "npx lerna publish --dist-tag next --preid rc --no-verify-access --conventional-prerelease",
"publish:release": "npx lerna publish --dist-tag latest --create-release github --no-verify-access --conventional-graduate bump minor",
"publish:hotfix": "npx lerna publish --dist-tag latest --no-verify-access --conventional-graduate bump patch",
"publish:nightly": "npx lerna publish --dist-tag nightly --no-verify-access --no-push --canary prerelease --preid nightly",
"publish:nightly": "npx lerna publish --dist-tag nightly --no-verify-access --conventional-prerelease --preid nightly --no-push",
"format": "npx prettier --write 'packages/**/src/**/*{.ts,.tsx,.js}'",
"lint": "npx lerna run lint && npx prettier --check packages/**/src/**/*.ts",
"clean": "npm run clean:deps && npm run clean:coverage && npm run clean:build-artifacts",
Expand Down

0 comments on commit 56f6526

Please sign in to comment.