ServiceNow provider update #129
Conversation
Add a filter to limit label to english
Fix the ticket number returned
|
Check on my centreon + snow instance, work fine |
There was a problem hiding this comment.
Hello pep-un, your PR is fine but in my opinion this is not the way we are going to implement it.
the first issue (changing sysTicketId for ticketId) requires an overhaul of the open ticket module. Service Now is one of the few ITSM software that is using a human readable ticket ID and an internal ID. The later being used to close the ticket through their REST API. This doesn't appear to be an issue with this provider since the close function is not implemented but it should.
Currently, we do not handle this kind of situation where we need to use two different ID for 1 ticket and this is a feature that we will do (and it will fix the Service Now provider)
the second issue is the language. This one is easier since it is specific to this provider. We can't force it to be english. Some will want it in spanish, french... The best way to solve this issue is to add another field in the rule form that let people set the language they want. Default being empty for update compatibilities purpose.
|
SonarQube Quality Gate:
|
|
I can understand my PR is not good enough, no shame on that I'm not a developer, but no one seems interested to fix it better than me. During this time the centreon-open-tickets plugin in not usable with service now, the biggest ITSM service on the market. Can you give me some track on how to fix the language issue ? Does centreon has a user field for the web interface language I can use ? |
|
SonarQube Quality Gate
|
Update the provider to filter the label returned by ServiceNow to english and fix the ticket number retruned after the creation.