Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Udate upload-artifact and download-artifact Github Actions #1522

Closed
wants to merge 2 commits into from
Closed

Udate upload-artifact and download-artifact Github Actions #1522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
369b541
udate upload-artifact
esseivaju Nov 26, 2024
532e8ed
update download-artifact action
esseivaju Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ jobs:
&& (steps.test.outcome == 'success'
|| steps.test.outcome == 'failure')
}}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: test-results-${{matrix.image}}-${{env.CMAKE_PRESET}}
path: "test-output/**/*.xml"
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/pull_request_completed.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Download and Extract Artifacts
uses: dawidd6/action-download-artifact@e7466d1a7587ed14867642c2ca74b5bcc1e19a2d # v6
uses: actions/download-artifact@v4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2 are not quite the same. The former allows to download this artifact in another workflow that is run after the first one.. Do we need that feature?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we do.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

download-artifact@v4 should now support this as well

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh good to know!

with:
name: "(event-file|test-results-.*)"
name_is_regexp: true
run_id: ${{github.event.workflow_run.id}}
pattern: "(event-file|test-results-.*)"
merge-multiple: true
run-id: ${{github.event.workflow_run.id}}
path: artifacts
- name: Publish PR comment
uses: EnricoMi/publish-unit-test-result-action@82082dac68ad6a19d980f8ce817e108b9f496c2a # v2.17.1
Expand Down
Loading