Udate upload-artifact and download-artifact Github Actions

[esseivaju]

This was probably missed during an update, as everywhere else already uses upload-artifact@v4. V3 will be deprecated soon.

[sethrj]

@esseivaju it doesn't work on the docker images because their OS is too old for the Node.js version. I guess v4 didn't work on ROCm in particular and now I've had to disable it. As I said I was going to update those images this week and the docker CI script that corresponds to it.

[pcanal]

The 2 are not quite the same. The former allows to download this artifact in another workflow that is run after the first one.. Do we need that feature?

[sethrj]

Yes we do.

[esseivaju]

download-artifact@v4 should now support this as well

[sethrj]

ooh good to know!

[github-actions]

Test summary

 3 844 files   5 936 suites   4m 9s ⏱️
 1 597 tests  1 569 ✅ 28 💤 0 ❌
19 790 runs  19 715 ✅ 75 💤 0 ❌

Results for commit 532e8ed.

[esseivaju]

@esseivaju it doesn't work on the docker images because their OS is too old for the Node.js version. I guess v4 didn't work on ROCm in particular and now I've had to disable it. As I said I was going to update those images this week and the docker CI script that corresponds to it.

Sure, I guess you can update everything in one go with the new images then.

[sethrj]

By the way @esseivaju , all changes to pull_request_completed have to be tested on develop on a personal repo before deploying to celeritas: those changes won't be tested as part of the PR (since it's the PR action on the develop branch that gets triggered), so I'd be happy to have those separate from the CI update.

[esseivaju]

@sethrj Sounds good; I'll test the update to pull_request_completed and re-open a new PR later.