minor ux improvements for scm #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
njbriggs
reviewed
Dec 13, 2023
| return '--'; | ||
| } | ||
|
|
||
| return moment(t.seconds * 1000).format('DD-MM-YYYY HH:mm:ss A'); |
There was a problem hiding this comment.
For future consideration: consolidate with date formatting logic in https://github.com/cdapio/cdap-ui/blob/develop/app/cdap/services/DataFormatter/index.ts
GnsP
force-pushed
the
scm-multi-ux-updates-610
branch
from
f62b5e8 to
5314d23
Compare
njbriggs
reviewed
Dec 13, 2023
| ? T.translate(`${PREFIX}.operationRanFor`).toString() | ||
| : T.translate(`${PREFIX}.operationRunningFor`).toString(); | ||
|
|
||
| return `${startedPrefix} ${startTime}, ${timeTakenPrefix} ${timeTaken}`; |
There was a problem hiding this comment.
We should not be using template literals to generate localized strings - some languages will expect segments to be in a different order. To be fully internationalized, this should be done through T.translate (L102 also)
There was a problem hiding this comment.
Agreed. This current implementation may not work properly in all cases, especially in RTL languages. Will update it.
njbriggs
approved these changes
Dec 13, 2023
sumengwang
approved these changes
Dec 13, 2023
GnsP
force-pushed
the
scm-multi-ux-updates-610
branch
from
5314d23 to
d8e5fcc
Compare
GnsP
force-pushed
the
scm-multi-ux-updates-610
branch
from
d8e5fcc to
ec04bcd
Compare
6 tasks
GnsP
added a commit
that referenced
this pull request
Dec 14, 2023
[🍒] minor ux improvements for scm (from #1160)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor ux improvements for scm
Description
Improves data fetching in the scm sync tab, and some copy changes.
Contains a subset of changes from #1157 , as the former PR got larger and not all changes there are cleared to be included in the release 6.10.0
PR Type
Links
Jira: CDAP-20917
Test Plan
e2e tests added already.
Screenshots
NA