Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scm bulk operations UX improvements #1157

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Scm bulk operations UX improvements #1157

wants to merge 3 commits into from

Conversation

GnsP
Copy link
Collaborator

@GnsP GnsP commented Dec 7, 2023 •
edited
Loading

SCM bulk operations UX improvements

Description

  1. Add better (more detailed) error message
  2. Add support for sync status, sorting and filtering pipelines in the scm sync page based on sync status.
  3. Add pagination for scm pipeline tables.
  4. Component refactors
  5. Remove 'pull from remote' button from the resource center modal.

PR Type

  • Bug Fix
  • Feature
  • Build Fix
  • Testing
  • General Improvement
  • Cherry Pick

Links

Jira: CDAP-20917

Test Plan

e2e tests have been added.

Screenshots

image

@GnsP GnsP force-pushed the scm-multi-ux-improvements branch 5 times, most recently from e275365 to e8aafe2 Compare December 7, 2023 12:23
@njbriggs
Copy link
Collaborator

njbriggs commented Dec 8, 2023

Can you add a Jira for this?

@GnsP GnsP force-pushed the scm-multi-ux-improvements branch 2 times, most recently from 1032c4f to 0f60f9e Compare December 8, 2023 04:25
@GnsP GnsP force-pushed the scm-multi-ux-improvements branch from 0f60f9e to afe28ce Compare December 8, 2023 08:08
@njbriggs
Copy link
Collaborator

njbriggs commented Dec 8, 2023

This is very large PR that seems to do multiple things. Can you split it up?

@GnsP GnsP force-pushed the scm-multi-ux-improvements branch 2 times, most recently from 42ec68c to df717e4 Compare December 12, 2023 05:33
@GnsP GnsP mentioned this pull request Dec 13, 2023
Merged
6 tasks
@GnsP
Copy link
Collaborator Author

GnsP commented Dec 13, 2023

Moved a subset of changes from here to #1160 as suggested by @njbriggs .

@GnsP GnsP force-pushed the scm-multi-ux-improvements branch from df717e4 to 3576aa7 Compare February 20, 2024 04:45
@GnsP GnsP force-pushed the scm-multi-ux-improvements branch from 01a9946 to 73d382b Compare February 20, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radhikav1 radhikav1 Awaiting requested review from radhikav1

@sumengwang sumengwang Awaiting requested review from sumengwang

@samdgupi samdgupi Awaiting requested review from samdgupi

@njbriggs njbriggs Awaiting requested review from njbriggs

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GnsP @njbriggs