fix: hydrogen sacs can stack, obsolete endochitin #4732
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
A while back I ran into an error with endochitin complaining about not being able to have charges, and haven't seen it trigger any since then, presumably due to #4707 making them stackable.
Now there's still one more non-stacking tissue item obtained by harvesting, so I'm thinking this should fix the associated bug but can't 100% confirm since I can't find a reliable way to force the bug to trigger in the first place.
Relevant issue: #4730
Along the way, in the BN server I was encouraged to obsolete endochitin as it really does nothing for us except flavor.
Describe the solution
stackable
to hydrogen sacs.I went ahead and kept hydrogen sacs for now since we might want to mainline hydrogen stuff from Cata++ anyway.
Describe alternatives you've considered
Obsoleting hydrogen sacs for being pointless flavor too. Hydrogen sacs have a use in Cata++ since hydrogen is craftable and used for stuff in it, but that's a third-party mod, and endochitin is still just outright useless.
Testing
I tried to mess around with hydrogen sacs before implementing this to see if there was a reliable way of triggering the error but couldn't find a way to force it to trigger the error message.
The old sacs from before I implemented it instead like to do this silliness once converted to stack:
Additional context
Checklist