Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (interface): new UDP external tileset sprite for signs #3670

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

chaosvolt
Copy link
Member

@chaosvolt chaosvolt commented Nov 14, 2023

Summary

SUMMARY: Interface "Add a new sprite for f_sign to the UDP external tileset, fixing the DDA lettering on it"

Purpose of change

Apollo over on the BN server pointed out we have a leftover of DDA we can't axe quite so easily:
image

Describe the solution

Added a new sign sprite to the external tileset.

Also updated the external tileset documentation, including stuff from #3626 that @NobleJake didn't doc.

Describe alternatives you've considered

Take your pick, the rightmost one is the variant currently used:
Signs Signs Everywhere A Sign

Testing

  1. Checked tile config JSON for syntax and lint errors.
  2. Loaded up compiled test build.
  3. Spawned in a sign.

image

Additional context

A terrible secret

image

[12:02 PM]Chaosvolt: Shrinking actual text down to a 18x9 space really does turn it into just a bunch of lines. XD
[12:03 PM]Chaosvolt: And no one but us will know it was originally in comic sans. :chaos~2:

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Nov 14, 2023
olanti-p
olanti-p previously approved these changes Nov 14, 2023
@chaosvolt
Copy link
Member Author

Had to update the doc as well. :>

@chaosvolt chaosvolt changed the title feat (interface): new UPD external tileset sprite for signs feat (interface): new UDP external tileset sprite for signs Nov 14, 2023
@olanti-p olanti-p added this pull request to the merge queue Nov 14, 2023
Merged via the queue into cataclysmbnteam:upload with commit fac99a0 Nov 14, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants