-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(content): looks_like
, trigger message with spells, and can alarm for trap
#3939
Conversation
The Autofix app has automatically formatted this Pull Request. If you edit your PR on web UI, you can ignore this message.
If you don't do this, your following work will be based on the old commit, and cause MERGE CONFLICT. |
doc/src/content/docs/en/mod/json/reference/graphics/external_tileset.md
Outdated
Show resolved
Hide resolved
…ileset.md Co-authored-by: scarf <[email protected]>
Side note, can alarms don't drop anything when triggered. I think for my next followup PR, instead of going straight to adding more traps, I'm gonna focus on JSONizing what drops when a trap is triggered. |
looks_like
, trigger message with spells, and can alarm for trap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Purpose of change
Some ideas that came up in the vein of making trapping less hassle to grind and for bonus points add more options using it. Led to a fix or two along the way.
WIP because I need this PR's number to finish the external_tileset.md update and because I might add more traps to this.
Describe the solution
C++ changes:
trapfunc::cast_spell
so that it prints a message when a trap is triggered by a player or NPC, as it doesn't print the spell's noise message when triggered by the player so the player really oughta have some warning.looks_like
for traps tocata_tiles::find_tile_looks_like
.looks_like
as used in other areas of the code.JSON changes:
adhesive
crafting quality in general, and added nails as an alternative.looks_like
pointing to tripwires for can alarms and booby traps.Doc changes:
Describe alternatives you've considered
Screaming and JSONizing trapfuncs. The latter will involve much of the former.
Testing
^
.Additional context
I'd REALLY like to figure out how to fix spellcasting traps needing a minimum AoE defined along with some of the other janky horseshit going on under the hood there, as then we could have basic shit like single-tile damaging spell traps for things like deadfalls or spear traps, without having to fuck about with either new trap funcs, struggling with JSONizing this crap, and/or limiting spellcasting traps to stuff where it being an AoE makes perfect sense.
I checked to see if DDA's version of Ultica (as of build 2023-11-21-0110) has more of its traps sprited or not, seems to not be the case, as booby traps are still using a fallback sprite. So tripwire sprite (which made it into our version of Ultica) is about to start getting some more use:
Checklist