fix: allow elevator misalignment

[scarf005]

Summary

SUMMARY: Bugfixes "Fix misaligned elevator not working due to misalignment"

Purpose of change

elevator misalignment was making elevator control not working.

Describe the solution

1. aligned sarcophagus elevator.
2. made elevator checks more forgiving (now considers up to 3-tile radius)
   3. inlined functions 'cause godbolt results told me they were more efficient

no inline (133 loc) vs inline (99 loc)

Tests

2023-09-19_22-56-01.mp4

[olanti-p]

inline is best suited for hot, or small and simple (like in your examples) functions where the call cost is noticeable relative to the work done. Using inline on large functions will inflate the size of the binary, which can actually worsen the performance on some CPUs, or it will simply do nothing because inline does not force the compiler to inline, it just advises it to, and the compiler is free to choose whether to inline the function or not regardless of whether the function has inline or not. It is hard to tell without a profiler whether you need to inline, and it can be hard to tell without disassembling the resulting binary whether the inline even worked.

In your 133 loc example, from what I can tell from the atrocious mobile UI, the compiler does inline the functions. It just does not eliminate functions themselves because they're not static, so the compiler thinks they can be used from other translation units, which would be impossible if they were eliminated.

TLDR: It is ok to have call overhead if you don't have a specific reason to avoid it.

[scarf005]

you're right, it's probably not worth it, as these functions aren't called in hot loop.

EDIT: C++ made same optimization (99loc) after adding anonymous namespace (== static linking).

[chaosvolt]

../tests/translations_test.cpp:147: warning:
  Skipped (unable to set locale)

D:\a\_temp\bfbeaa38-6fcb-4d6b-806d-d1350dacae97: line 1:  1382 Segmentation fault      ./tests/cata_test.exe --rng-seed time

Unrelated I hope?

[scarf005]

@chaosvolt i think this one is ready too