-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: apply clang-tidy performance checks #3393
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
applied clang-tidy to fix `-Wpessimizing-move`, and activiy being changed to pointer Co-authored-by: jove <[email protected]>
Co-authored-by: jove <[email protected]>
fix: various build blockers
build: 0.4 merge preparation
github-actions
bot
added
src
changes related to source code.
tests
changes related to tests
labels
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lang/notes
(docs:lang/notes
#3207)item::has_flag
calls #3277)sm_to_ms_copy
(perf(map): inlinesm_to_ms_copy
#3278)cached_dead_state
if npc is actually dead (fix: only setcached_dead_state
if npc is actually dead #3287)best_mode_for_range()
(Use std::optional forbest_mode_for_range()
#3368)weight_carried_reduced_by
andrecalc_speed_bonus
(perf: slightly speed upweight_carried_reduced_by
andrecalc_speed_bonus
#3385)emplace_back