Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto ladder climbing and ledge prompts #3141

Merged
merged 5 commits into from
Sep 15, 2023

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Sep 15, 2023

Summary

SUMMARY: Features "Made ladders work like ramps and ledges auto-examinable"

Purpose of change

There's two way of going down a ledge:

  1. jump down (may hurt)
  2. climb down

option 2 can only be accessed via (e)xamine, and 90% of time climbing down is a better choice.

moving z-levels up and down with stepladders were also tiresome.

Describe the solution

  1. made game::prompt_dangerous_tile to call iexamine::ledge instead if and only if dangerous terrain is ledge.
  2. made furniture with LADDER flag act as ramps. when climbing up, the check is done just before handling invalid moves to not interfere with walking, opening door, etc.

Describe alternatives you've considered

  • make it an option?
  • make auto ledge examine more granular depending on Dangerous terrain warning prompt?

Testing

2023-09-15_14-19-02.mp4
2023-09-15_15-22-38.mp4

auto ladder and grappling hooks climbing (anything with LADDER flag will work)

2023-09-15_15-10-41.mp4

auto ledge prompts

@scarf005 scarf005 requested a review from olanti-p September 15, 2023 06:28
@github-actions github-actions bot added the src changes related to source code. label Sep 15, 2023
@olanti-p olanti-p merged commit 52f8249 into cataclysmbnteam:upload Sep 15, 2023
16 checks passed
@scarf005 scarf005 deleted the walk-down-ladders branch September 15, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants