Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DE-7017: Generic improvements #37

Merged
merged 26 commits into from
Apr 8, 2024
Merged

DE-7017: Generic improvements #37

merged 26 commits into from
Apr 8, 2024

Conversation

fingerartur
Copy link
Contributor

@fingerartur fingerartur commented Apr 8, 2024 •
edited
Loading

Here I'm making a few generic improvements.

## New Features

* Add option to keep player controls hidden.
* Make `BaseThemeOverlay` more configurable:
  * Add option to hide buttons (audio, full screen, track options)
  * Add option to hide the top bar of player controls
  * Add option to render a companion component above the bottom bar
    of player controls
* Add option to display cues on the seek bar

## Fixes

* Fix rounding of duration.

fingerartur added 26 commits April 7, 2024 20:49
@fingerartur
App: Move index.html to root folder
fc51d73
@fingerartur
App: Add mux.js to support HLS playback
b89ad11
@fingerartur
Add prepack script
beb08e5 
This way it is easy to pack TGZ NPM packages for local use.
@fingerartur
ADD controlsVisibility to base theme
6cec87c 
In order to configure visibility of UI controls.
@fingerartur
ADD the option to hide UI controls
c33eddc 
Option: 'never'
@fingerartur
ESlint: disable a miss-reported rule
611b41a 
`@typescript-eslint/no-unsafe-assignment` it is getting reported in situations where it there is no
reason for it.
@fingerartur
FIX rounding of duration
79d2919 
Now all values with remainder 0.8 and higher
are rounded UP instead of down, to produce
a more accurate value.
@fingerartur
Extract disposer type
664bb58
@fingerartur
Base theme make configurable: audio controls, full screen button, tra…
b600625 
…ck controls
@fingerartur
Refactor
62615b4
@fingerartur
Refactor: Get rid of unnecessary private annotations
8547906
@fingerartur
Make presto context attribute nullable
359a8e2
@fingerartur
Refactor listeners to PRESTOplay instance
8cbecbe
@fingerartur
lint
e4649f3
@fingerartur
Fix context filter
798efd8
@fingerartur
ADD support for UI cues (so far empty)
b485716
@fingerartur
Support gold seek bar color
bd006a1
@fingerartur
ADD renderBottomCompanion, showInterstitialMarkers, showSeekBarCues t…
9362d8c 
…o base theme
@fingerartur
Add last playback state to player
89fa42f
@fingerartur
Player: store and check last playback state
561371c
@fingerartur
Player: support ignore of state 'ended'
db41ad9
@fingerartur
Player protected methods
ee9074d
@fingerartur
Add safe z-index to ui-overlay
f68c983
@fingerartur
Support cues
d3310e3
@fingerartur
Fix presto listeners
055976d
@fingerartur
changelog
f0be44f
@fingerartur fingerartur requested a review from thasso April 8, 2024 09:32
@fingerartur fingerartur merged commit 88cb5a7 into main Apr 8, 2024
2 checks passed
@fingerartur fingerartur deleted the fix/DE-7017-generic-fixes branch April 8, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thasso thasso thasso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fingerartur @thasso